Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add overwriteChainableMethod utility #219

Merged
merged 3 commits into from
Dec 20, 2013

Conversation

hazeledmands
Copy link

Here you go. I ended up storing the original method and chaining behavior in a global object, which makes me feel a bit dirty, but there it is. Not sure how else this could be done without significantly modifying the plugin API.

Ref: #215.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fe192c5 on demands:overwrite_chainable into 0e560c6 on chaijs:master.

@hazeledmands
Copy link
Author

Oops. Karma tests don't pass. Attempting to fix...

@hazeledmands
Copy link
Author

There. Forgot to add the new file to components.json.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2127525 on demands:overwrite_chainable into 0e560c6 on chaijs:master.

@logicalparadox
Copy link
Member

Do you have a SauceLabs account so you can run the full browser test suite? If not you can get an Open Sauce account or I can provide temporary credentials:

// test/auth/index.js
module.exports = {
  SAUCE_USERNAME: "[username]",
  SAUCE_ACCESS_KEY: "[access key]"
};
$ make test-sauce

@hazeledmands
Copy link
Author

Right on, thanks :) Running them now.

@hazeledmands
Copy link
Author

Looks like they all passed. Never used saucelabs before! I am impressed :)

@logicalparadox
Copy link
Member

Comments inline ... let me know your thoughts.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 576d890 on demands:overwrite_chainable into 0e560c6 on chaijs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 76ac685 on demands:overwrite_chainable into 0e560c6 on chaijs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 270f9d9 on demands:overwrite_chainable into 0e560c6 on chaijs:master.

@hazeledmands
Copy link
Author

Ping -- what can I do to get this merged?

@vesln
Copy link
Member

vesln commented Dec 20, 2013

I'm happy to merge it in, however since @logicalparadox did the initial comments, it I'd prefer to wait for him to do so.

logicalparadox added a commit that referenced this pull request Dec 20, 2013
Add overwriteChainableMethod utility
@logicalparadox logicalparadox merged commit 564af34 into chaijs:master Dec 20, 2013
@hazeledmands hazeledmands deleted the overwrite_chainable branch January 28, 2014 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants