-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add overwriteChainableMethod utility #219
Add overwriteChainableMethod utility #219
Conversation
Oops. Karma tests don't pass. Attempting to fix... |
There. Forgot to add the new file to |
Do you have a SauceLabs account so you can run the full browser test suite? If not you can get an Open Sauce account or I can provide temporary credentials: // test/auth/index.js
module.exports = {
SAUCE_USERNAME: "[username]",
SAUCE_ACCESS_KEY: "[access key]"
};
|
Right on, thanks :) Running them now. |
Looks like they all passed. Never used saucelabs before! I am impressed :) |
Comments inline ... let me know your thoughts. |
Ping -- what can I do to get this merged? |
I'm happy to merge it in, however since @logicalparadox did the initial comments, it I'd prefer to wait for him to do so. |
Add overwriteChainableMethod utility
Here you go. I ended up storing the original method and chaining behavior in a global object, which makes me feel a bit dirty, but there it is. Not sure how else this could be done without significantly modifying the plugin API.
Ref: #215.