Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

return error on throw method to chain on error properties #224

Merged
merged 1 commit into from
Jan 2, 2014
Merged

return error on throw method to chain on error properties #224

merged 1 commit into from
Jan 2, 2014

Conversation

vbardales
Copy link

Allow to create that type of assertions:

expect(fn).to.throw(BadArgumentError).that.have.property('code', 500);

by chaining on the error instance, not on the function that throw an error

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c32ae3e on vbardales:master into 0e560c6 on chaijs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2bb0ff2 on vbardales:master into 0e560c6 on chaijs:master.

@vbardales
Copy link
Author

up ?

@vesln
Copy link
Member

vesln commented Jan 2, 2014

Makes sense to me. @logicalparadox?

@logicalparadox
Copy link
Member

👍

vesln added a commit that referenced this pull request Jan 2, 2014
Return error on throw method to chain on error properties
@vesln vesln merged commit f3ebb09 into chaijs:master Jan 2, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants