Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add pubsub integration tests #69

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Add pubsub integration tests #69

merged 4 commits into from
Jan 24, 2024

Conversation

mempirate
Copy link
Contributor

Minor changes + pubsub integration tests (ignored for now but all passing locally)

@mempirate mempirate requested a review from merklefruit January 24, 2024 10:31
merklefruit
merklefruit approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tried the tests locally yet though

@mempirate
Copy link
Contributor Author

LGTM, haven't tried the tests locally yet though

You can run with cargo test pubsub -- --ignored

@mempirate mempirate merged commit 7a4d594 into main Jan 24, 2024
7 checks passed
@mempirate mempirate deleted the test/integration-tests branch January 24, 2024 10:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mempirate @merklefruit