Test rsgcn #146
Merged
Test rsgcn #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 75.44% 76.82% +1.38%
==========================================
Files 77 78 +1
Lines 3213 3271 +58
==========================================
+ Hits 2424 2513 +89
+ Misses 789 758 -31 |
delta2323
requested changes
Apr 21, 2018
tests/models_tests/test_rsgcn.py
Outdated
| ).astype(numpy.int32) | ||
| # adj_data = numpy.random.randint( | ||
| # 0, high=2, size=(batch_size, atom_size, atom_size) | ||
| # ).astype(numpy.float32) |
tests/models_tests/test_rsgcn.py
Outdated
| 0, high=1, size=(batch_size, atom_size, atom_size) | ||
| ).astype(numpy.float32) | ||
| adj_data = adj_data + adj_data.swapaxes(-1, -2) | ||
| # adj_data = (adj_data > 1.5).astype(numpy.float32) |
|
Regarding stochastic behavior of |
|
Is this change enough? |
|
Regarding my previous comment, it is OK to me to focus on deterministic behavior of dropout in another PR. |
|
Could you merge if there is no request changes? |
|
Example tests passed. |
delta2323
approved these changes
Apr 23, 2018
|
I created #153 for the dropout issue. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropout_ratioattribute to control dropout ratio in RSGCN.