-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding an initial version of reusable workflow for chainloop. #1
Conversation
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Added some comments but approving it
.github/workflows/chainloop.yml
Outdated
required: false | ||
type: string | ||
secrets: | ||
token: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be more specific about what this is. what about workflow_robot_account
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted something shorter.
curl -sfL https://docs.chainloop.dev/install.sh | bash -s | ||
fi | ||
|
||
- name: Download all workflow run artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are github workflow runs artifact correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
.github/workflows/chainloop.yml
Outdated
|
||
- name: Add all artifacts, reports, and metadata to attestation. | ||
run: | | ||
script=`cat .chainloop/config.yml | yq eval '.attestation[] | "chainloop attestation add --name " + .name + " --value " + .path + "; "'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think we need to have a chainloop directory?
I would potentially prefer just a .chainloop.yml file. That way it's similar to .goreleaser.yaml
, .golangcilint.yaml
, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was storing the contract, this config in this folder. I can change it
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
This is how the workflow is going to be used:
You will need to use upload-artifact action to share all metadata which you want to store in Chainloop.
Finally we expect the
.chainloop/config.yml
config file to provide information about metadata files to be stored. Example: