security fix 2 - Only send a getheaders for one block in an INV #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in an INV functional for this is a variant of the same test in bitcoin.
azuchi
reviewed
Sep 13, 2024
|
|
||
| # Wait for peer1 to receive a getheaders | ||
| # If no block hash is provided, checks whether any getheaders message has been received by the node.""" | ||
| def test_function(): |
There was a problem hiding this comment.
Bitcoin uses the wait_for_getheaders method, but why did you create this method?
There was a problem hiding this comment.
This method is from the implementation of wait_for_getheaders copied from bitcoin test framework as it is.
There was a problem hiding this comment.
It seems that the same method exists in mininode.py in Tapyrus Core. Can we use that to write it in the same way?
azuchi
approved these changes
Sep 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port fixes from bitcoin: 18962 - Only send a getheaders for one block in an INV
Functional test for this is ported from bitcoin. But the expected results are different from the same test in bitcoin. This is because of the protocol changes made in bitcoin regarding the number of peers to get headers from during IBD. In papyrus there is no restriction. so all peers get and send the headers message.