Security fix 4 - Simplify node time and network-adjusted time warning logic #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the timeoffset defined in each node, all time functions defined in tapyrus are affected use std::chrono::system_clock is used to get the time in GetTime, GetAdjustedTime, GetSystemTimeInSeconds, GetTimeMillis and GetTimeMicros. This system time takes into account the mocktime used testing also.
…Time, GetAdjustedTime, GetSystemTimeInSeconds, GetTimeMillis and GetTimeMicros. This system time takes into account the mocktime used testing also.
…all to addrandonoutboundpeer
azuchi
requested changes
Oct 29, 2024
azuchi
requested changes
Oct 29, 2024
|
…dd timeoffset to peerinfo in UI
but, |
I tried to remove it, but this is used in the GUI after the previous commit ( |
Naviabheeman
force-pushed
the
Securityfix4_node_time
branch
from
58603dc to
abe5184
Compare
azuchi
approved these changes
Nov 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port fix of vulnerability fix of Disclosure of netsplit due to timestamp adjustment which was changed later by PR 29623(Simplify network-adjusted time warning logic)
As this PR removes the
timeoffsetpreviously defined in each node, the notion of 'adjusted time' is also removed. So a unifiedstd::chrono::system_clockis used to get the time in GetTime, GetAdjustedTime, GetSystemTimeInSeconds, GetTimeMillis and GetTimeMicros.GetAdjustedTimeandGetTimeare now the same. They return the mockable system time.GetSystemTimeInSecondsdoes not allow mocktime. This is essential as the p2p layer depends heavily on the connection and message time. Any change to this time due to mocking results in unpredictable behaviour in functional tests.