Fix incorrect abort in EntryIntl_PluralRulesSelect

When rounding a number to "x significant figures" Rounding diff can be arbitrarily large There was an abort for rounding diffs > 1 invalid in many cases.
chakra-core · Mar 21, 2021 · 7d992aa · 7d992aa
1 parent 75d3cf4
commit 7d992aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp b/lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp
@@ -3128,8 +3128,10 @@ DEFINE_ISXLOCALEAVAILABLE(PR, uloc)
         }, scriptContext->GetRecycler(), &formattedN, &formattedNLength);
 
         double nWithOptions = unum_parseDouble(*nf, reinterpret_cast<UChar *>(formattedN), formattedNLength, nullptr, &status);
-        double roundtripDiff = n - nWithOptions;
-        ICU_ASSERT(status, roundtripDiff <= 1.0 && roundtripDiff >= -1.0);
+
+        ICU_ASSERT(status, (n > 0.0 && nWithOptions <= n && nWithOptions >= 0.0) ||
+            (n < 0.0 && nWithOptions >= n && nWithOptions <= 0) ||
+            (n == 0.0 && nWithOptions == 0));
 
         char16 *selected = nullptr;
         int selectedLength = 0;

diff --git a/test/Intl/PluralRules.js b/test/Intl/PluralRules.js
@@ -159,6 +159,9 @@ testRunner.runTests([
             test({ maximumSignificantDigits: 1 }, 1.0, "one");
             test({ maximumSignificantDigits: 1 }, 1.1, "one");
             test({ maximumSignificantDigits: 1 }, 1.001, "one");
+            test({ maximumSignificantDigits: 1 }, 110.001, "many");
+            test({ maximumSignificantDigits: 1 }, -110.001, "many");
+            test({ maximumSignificantDigits: 1 }, -1, "one");
 
             // significantDigits should override fractionDigits and integerDigits
             test({ maximumSignificantDigits: 2, maximumFractionDigits: 0 }, 1.1, "other");