Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MicroBuild v2: Fix string formatting in change.txt. #1132

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented Jun 13, 2016

This change is Reviewable

@dilijev
Copy link
Contributor Author

dilijev commented Jun 13, 2016

@Cellule Review please?

@dilijev
Copy link
Contributor Author

dilijev commented Jun 13, 2016

@Cellule was this infra-blocking or just cosmetic? (How hard should I try to get this change into all branches?)

@Cellule
Copy link
Contributor

Cellule commented Jun 14, 2016

It's not infra blocking, but reporting tool will miss the commit description which is annoying

@Cellule
Copy link
Contributor

Cellule commented Jun 14, 2016

lgtm

@dilijev
Copy link
Contributor Author

dilijev commented Jun 14, 2016

@Cellule, okay, merging this into release/1.2 will eventually propagate to most branches. I think I won't worry about backporting this to release/1.1 unless we have some activity there or another round of breaking Microbuild v2 changes. @ianwjhalliday does that sound okay?

@chakrabot chakrabot merged commit 0ab6819 into chakra-core:release/1.2 Jun 14, 2016
chakrabot pushed a commit that referenced this pull request Jun 14, 2016
Merge pull request #1132 from dilijev:microbuildv2
@dilijev dilijev deleted the microbuildv2 branch June 14, 2016 20:30
chakrabot pushed a commit that referenced this pull request Jun 14, 2016
…ange.txt.

Merge pull request #1132 from dilijev:microbuildv2
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants