Change to address CVE-2016-7202 #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Array.prototype.reverse, array length is cached and used in ReverseHelper(). ReverseHelper() could invoke FillFromPrototypes(), which can cause a side-effect on the array, including changing its length. Therefore, the use of cached array length to calculate segment left index could result in overflow. Fix by clamping array length at zero.
suwc
force-pushed
the
build/suwc/bugfix
branch
from
1f4e125 to
eecf271
Compare
|
@pleath or @boingoing could you approve pls? |
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Dec 13, 2016
Merge pull request #2196 from suwc:build/suwc/bugfix Heap overflow in Array.prototype.reverse In Array.prototype.reverse, array length is cached and used in ReverseHelper(). ReverseHelper() could invoke FillFromPrototypes(), which can cause a side-effect on the array, including changing its length. Therefore, the use of cached array length to calculate segment left index could result in overflow. Fix by clamping array length at zero.
chakrabot
pushed a commit
that referenced
this pull request
Dec 13, 2016
Merge pull request #2196 from suwc:build/suwc/bugfix Heap overflow in Array.prototype.reverse In Array.prototype.reverse, array length is cached and used in ReverseHelper(). ReverseHelper() could invoke FillFromPrototypes(), which can cause a side-effect on the array, including changing its length. Therefore, the use of cached array length to calculate segment left index could result in overflow. Fix by clamping array length at zero.
chakrabot
pushed a commit
that referenced
this pull request
Dec 13, 2016
Merge pull request #2196 from suwc:build/suwc/bugfix Heap overflow in Array.prototype.reverse In Array.prototype.reverse, array length is cached and used in ReverseHelper(). ReverseHelper() could invoke FillFromPrototypes(), which can cause a side-effect on the array, including changing its length. Therefore, the use of cached array length to calculate segment left index could result in overflow. Fix by clamping array length at zero.
chakrabot
pushed a commit
that referenced
this pull request
Dec 13, 2016
…CVE-2016-7202 Merge pull request #2196 from suwc:build/suwc/bugfix Heap overflow in Array.prototype.reverse In Array.prototype.reverse, array length is cached and used in ReverseHelper(). ReverseHelper() could invoke FillFromPrototypes(), which can cause a side-effect on the array, including changing its length. Therefore, the use of cached array length to calculate segment left index could result in overflow. Fix by clamping array length at zero.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heap overflow in Array.prototype.reverse
In Array.prototype.reverse, array length is cached and used in ReverseHelper().
ReverseHelper() could invoke FillFromPrototypes(), which can cause a side-effect on the array,
including changing its length. Therefore, the use of cached array length to calculate segment left index could result in overflow. Fix by clamping array length at zero.