Fix futex_fatal_error -- issue #6931 #6932
Conversation
In cclock.hpp we reserve storage for a mutex, but didn't specify alignment for it (except on ARM64). That resulted in an unaligned pthread_mutex_t on Linux, when built with Clang 14.0.6 on x86_64 Ubuntu.
|
Hi @EmployedRussian thank you for this proposed fix, and I'm very sorry about the long delay - I wasn't aware of this PR until someone tagged me in a related issue. I've tried adding Ubuntu 22 CI to test it in #6975 a debug build works with this but a Test build (Release with Debug Info) does not; do you have any scope or desire to look at this further? |
|
We've now found the other bug and it's unrelated (though also a necessary fix for Ubuntu 22). Would you like this PR to be merged? Would ideally need you to sign our contributor agreement: https://github.com/chakra-core/ChakraCore/blob/master/ContributionAgreement.md Thank you very much for finding what this problem was. |
Sure.
Done. #6979 |
ChakraCore recently released a fix for a critical issue: crashing on some Linux distributions. chakra-core/ChakraCore#6932
In cclock.hpp we reserve storage for a mutex, but didn't specify alignment for it (except on ARM64).
That resulted in an unaligned pthread_mutex_t on Linux, when built with Clang 14.0.6 on x86_64 Ubuntu.