Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Avatar's style overrides to work the same way as before #1335

Merged
merged 3 commits into from
May 12, 2023

Conversation

sungik-choi
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

Avatar 의 스타일링이 이전과 같은 방식으로 동작하도록 수정합니다.

Details

  • Implement AlphaSmoothCornersBox component #1317 의 side effect. 스타일 우선순위가 변경되어 Avatar 의 스타일 오버라이드가 잘 되지 않는 문제가 발생했습니다.
  • WrapperclassName 속성을 주입하여 이전과 같은 방식으로 스타일링이 잘 되도록 변경합니다.
  • 불필요한 wrapper* 추가 스타일 속성을 제거합니다.

Breaking change or not (Yes/No)

Yes

  • Delete wrapperStyle prop of AvatarProps.
  • Delete wrapperClassName prop of AvatarProps.
  • Delete wrapperInterpolation prop of AvatarProps.

References

None

@sungik-choi sungik-choi added the fix PR related to bug fix label May 12, 2023
@sungik-choi sungik-choi self-assigned this May 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: 29806a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c0fe743) 84.27% compared to head (29806a1) 84.27%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1335   +/-   ##
========================================
  Coverage    84.27%   84.27%           
========================================
  Files          309      309           
  Lines         3917     3917           
  Branches       802      803    +1     
========================================
  Hits          3301     3301           
  Misses         546      546           
  Partials        70       70           
Impacted Files Coverage Δ
...eact/src/components/Avatars/Avatar/Avatar.types.ts 100.00% <ø> (ø)
.../Avatars/CheckableAvatar/CheckableAvatar.styled.ts 100.00% <ø> (ø)
...act/src/components/Avatars/Avatar/Avatar.styled.ts 100.00% <100.00%> (ø)
...ier-react/src/components/Avatars/Avatar/Avatar.tsx 95.00% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit a8a2a78 into channel-io:next-v1 May 12, 2023
@sungik-choi sungik-choi deleted the fix/avatar-styling branch May 12, 2023 08:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix PR related to bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant