Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: minor refactors #184

Merged
merged 3 commits into from
Aug 5, 2024
Merged

chore: minor refactors #184

merged 3 commits into from
Aug 5, 2024

Conversation

manasaV3
Copy link
Contributor

@manasaV3 manasaV3 commented Aug 3, 2024 •
edited
Loading

Description

  • Minor refactor to make a method name more generalized, as the method is used for both tiltseries volumes and tomogram volumes.
  • Updating the sources for the unavailable tiltseries to return empty list instead of causing error during ingestion

@manasaV3 manasaV3 requested review from daniel-ji and jgadling August 3, 2024 00:37
@manasaV3 manasaV3 changed the title chore: Refactoring method name chore: minor refactors Aug 3, 2024
@daniel-ji daniel-ji self-requested a review August 3, 2024 00:54
@manasaV3 manasaV3 merged commit 6dd74ef into main Aug 5, 2024
5 checks passed
@manasaV3 manasaV3 deleted the mvenkatakrishnan/minor_fix branch August 5, 2024 16:56
daniel-ji pushed a commit that referenced this pull request Aug 12, 2024
@manasaV3 @daniel-ji
chore: minor refactors (#184)
bd7425f 
* Refactoring method name

* Refactoring unavailable ts placeholder

* Updating name
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@daniel-ji daniel-ji daniel-ji approved these changes

@jgadling jgadling Awaiting requested review from jgadling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manasaV3 @daniel-ji