Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: test rdev #449

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/argus-stack-rdev-create.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ jobs:

steps:
- name: Create Stack
id: upsert
uses: chanzuckerberg/argus-artifacts/ci/packages/create-stack@v0.49.1
with:
appName: cryoet-apiv2
envName: rdev
waitForDeploymentSeconds: 600

4 changes: 1 addition & 3 deletions .github/workflows/docker-build-rdev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: Docker Build Rdev
on:
pull_request:
types: [ labeled, synchronize ]
paths:
- 'apiv2/**'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -17,4 +15,4 @@ jobs:
if: contains(github.event.pull_request.labels.*.name, 'stack') && github.event.sender.type != 'Bot'
with:
envs: rdev
path_filters: 'apiv2/**'
path_filters: apiv2/**
8 changes: 4 additions & 4 deletions .infra/rdev/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ stack:
services:
apiv2:
image:
tag: sha-4f0ca7f
tag: sha-07d9cdb
initContainers:
# Install cerbos policies where the cerbos sidecar can grab them.
- name: install-cerbos-policies
image:
repository: 533267185808.dkr.ecr.us-west-2.amazonaws.com/core-platform/cryoet-data-portal-backend/apiv2/apiv2
tag: sha-4f0ca7f
tag: sha-07d9cdb
command: ["cp", "-r", "./cerbos/", "/var/policies/"]
volumeMounts:
- mountPath: /var/policies
Expand All @@ -24,7 +24,7 @@ stack:
- name: run-migrations
image:
repository: 533267185808.dkr.ecr.us-west-2.amazonaws.com/core-platform/cryoet-data-portal-backend/apiv2/apiv2
tag: sha-4f0ca7f
tag: sha-07d9cdb
command: ["alembic", "upgrade", "head"]
resources:
limits:
Expand All @@ -37,7 +37,7 @@ stack:
- name: gen-keypair
image:
repository: 533267185808.dkr.ecr.us-west-2.amazonaws.com/core-platform/cryoet-data-portal-backend/apiv2/apiv2
tag: sha-4f0ca7f
tag: sha-07d9cdb
command: ["bash", "./etc/gen_keys.sh", "/var/keys/"]
volumeMounts:
- mountPath: /var/keys
Expand Down
2 changes: 1 addition & 1 deletion apiv2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ $ FILE=tests/test_aggregates.py make test-file

```
# First, make any necessary changes to `apiv2/schema/schema.yaml`, then run this to generate new code & migrations and apply them:

cd apiv2
make update-schema

Expand All @@ -55,6 +54,7 @@ cd ..
pre-commit run --all-files

# Then commit all changed files, *including* any new migrations!

git commit -am "chore: Updating schema to add X feature"

```
Expand Down
Loading