-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(button): update button sizes in icon only to have a minimum width #2130
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2130 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 114 114
Lines 2829 2829
Branches 764 764
=======================================
Hits 2748 2748
Misses 77 77
Partials 4 4 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
2f8ad5d
to
162944c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments. Beyond that, I'll leave it up to you whether the changes seen in Chromatic are good.
Turns out those two snapshots had a hidden example of the same issue seen in the sort buttons used in the |
Previously, the button styles when
icon-only
would unset the minimum width to take on a perfectly circular shape. This is fine in default cases, but would cause the button to lose width when used in a flex context, like inDataTable
. Instead ofunset
ting the width for icon-only, add amin-width
to each button size when layout is icon-only.Test Plan: