Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feature] configure bless providers with a role #494

Merged

Conversation

ryanking
Copy link
Contributor

@ryanking ryanking commented Sep 8, 2020

Allow configuring bless providers with a role_arn, in addition to a profile.

Support was
previously
added to the provider.

Test Plan

  • unit tests

References

Allow configuring bless providers with a role_arn, in addition to a profile.

Support was
[previously](chanzuckerberg/terraform-provider-bless#33)
added to the provider.
@ryanking ryanking requested a review from edulop91 September 8, 2020 20:30
@ryanking ryanking requested a review from a team as a code owner September 8, 2020 20:30
@codecov-commenter
Copy link

Codecov Report

Merging #494 into master will increase coverage by 0.44%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   59.27%   59.72%   +0.44%     
==========================================
  Files          19       19              
  Lines        1994     2001       +7     
==========================================
+ Hits         1182     1195      +13     
+ Misses        654      649       -5     
+ Partials      158      157       -1     
Impacted Files Coverage Δ
config/v2/config.go 8.60% <ø> (ø)
config/v2/validation.go 78.85% <0.00%> (ø)
config/v2/resolvers.go 50.00% <100.00%> (+0.77%) ⬆️
plan/plan.go 85.94% <100.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cc774...40a7768. Read the comment docs.

@ryanking ryanking requested a review from jgadling September 9, 2020 17:15
@czimergebot czimergebot merged commit 588ecb1 into master Sep 9, 2020
@czimergebot czimergebot deleted the rking/ch16968/fogg-support-for-bless-provider-role-arn branch September 9, 2020 18:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants