-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(design-tokens): fixed font family #921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much for the quick update, Masoud 👏 !!
Non blocking - It seems like the system fonts are specific to macos, wondering what the impact would be on Windows, Linux, etc. 🤔
Ahh, thanks for the quick review @tihuan 😍🙏🏻🥳
I also came across this article that mentions how platforms like GitHub and Medium use similar fallback fonts for their font stacks. |
Ahh brilliant! Thanks so much for the rundown, Masoud 😁💡 That looks awesome! Could you please add the article link to the code for future reference too please? Thanks a lot! |
You’re welcome! 😍🥳🎉 |
@@ -1,3 +1,16 @@ | |||
/* Font-family explanation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect! Thanks for taking the time to do it 🤩 🏆 🙏
Summary
Design Tokens
Github issue: #920
https://czi-sci.slack.com/archives/C032S43KKFV/p1736185365071589
The SDS Tailwind configuration previously overrode the
font-family
toInter, sans-serif
, which does not fully meet the product requirements.This PR refactors the default
font-family
to use theInter
font defined via Next.js Fonts by default, with a fallback to a list of system fonts for better compatibility and consistency.