Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reruns bundle exec srb rbi hidden-definitions, resolves typecheck #66

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

mattxwang
Copy link
Contributor

@mattxwang mattxwang commented Jul 20, 2022

This PR fixes the problem on master, which was introduced with a new version of a gem (bundler? or maybe the runtime RBI reflection is not consistent, since the sorbet-runtime is the update I have when building from scratch) - our RBIs were out of date in-between when the CI check last ran and when we merged the PR.

I could see this problem happening more in the future: between the last CI check for a PR and it being merged, a gem is updated; bundler will resolve them differently (using the newer version on merge), and this could cause a mismatched RBI error.

Nominally, this fixes the problem, but this seems like a brittle issue (since we don't lock the gems we test against with a Gemfile.lock). Any thoughts on how to prevent this from being an issue in the future?

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #66 (5870f88) into master (c3a374d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   99.14%   99.22%   +0.07%     
==========================================
  Files           6        6              
  Lines         350      386      +36     
==========================================
+ Hits          347      383      +36     
  Misses          3        3              
Impacted Files Coverage Δ
lib/sorbet-coerce/converter.rb 97.36% <100.00%> (+0.22%) ⬆️
spec/coerce_spec.rb 100.00% <100.00%> (ø)

@mattxwang mattxwang requested a review from shitchcock July 20, 2022 17:50
@mattxwang mattxwang merged commit a72621f into master Jul 21, 2022
@mattxwang mattxwang deleted the mwang/regen-hidden-rbi branch July 21, 2022 16:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant