Reruns bundle exec srb rbi hidden-definitions
, resolves typecheck
#66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem on
master
, which was introduced with a new version of a gem (bundler? or maybe the runtime RBI reflection is not consistent, since the sorbet-runtime is the update I have when building from scratch) - our RBIs were out of date in-between when the CI check last ran and when we merged the PR.I could see this problem happening more in the future: between the last CI check for a PR and it being merged, a gem is updated; bundler will resolve them differently (using the newer version on merge), and this could cause a mismatched RBI error.
Nominally, this fixes the problem, but this seems like a brittle issue (since we don't lock the gems we test against with a
Gemfile.lock
). Any thoughts on how to prevent this from being an issue in the future?