Need more chaos #48
Merged
Need more chaos #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Zidail
commented
May 23, 2017
Zidail
commented
|
Nope, in order to prevent PRs like this. |
|
Outstanding attempt, though. I kinda want to +1 it just for that... |
drindc24
approved these changes
May 23, 2017
|
What |
|
Well that didn't take long. |
|
Uh... so is there a bug in the vote counting code or something? The merge commit (9500e94) claims there were only two votes on this PR (both in favor), when in reality there were over a hundred. |
|
Possible explanation for why this got merged: #82 (comment) |
Merged
Closed
chaosbot
added a commit
that referenced
this pull request
May 24, 2017
#152: Voting threshold Description: There should be a voting threshold (it's actually a threshold on the votes _difference_). Set to 1% of repo followers (currently, that means the difference between 👍 and 👎 should be at least 12). Prevents things like #138 and #48. Maybe we can change this later to use a percentage of active contributors instead of (possibly passive) stargazers? Not sure how to calculate that atm though. :ok_woman: PR passed with a vote of 18 for and 2 against, with a weighted total of 16.0 and a threshold of 1.0. Vote record: @ECrownofFire: 1 @manawasp: -1 @Vad1mo: 1 @andrewda: 1 @bperson: 1 @chipironcin: 1 @davidak: 1 @frazr: 1 @hongaar: 1 @kurokikaze: 1 @lukeramsden: 1 @pivotal-avenkatesh: 1 @qgustavor: 1 @reddraggone9: 1 @rhengles: 1 @richardjonathonharris: 1 @rudehn: 1 @tarunbatra: -1 @viktorsec: 1 @xyproto: 1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.