Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose access to Reason Codes #154

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Expose access to Reason Codes #154

merged 1 commit into from
Jul 18, 2017

Conversation

blakeprudhomme
Copy link
Contributor

Simply allows access to fetch the list of reason codes

@blakeprudhomme
Copy link
Contributor Author

blakeprudhomme commented May 12, 2017

Any feedback on this?

@wsmoak
Copy link
Contributor

wsmoak commented May 12, 2017

Sorry for the delay! Can you add something under the /examples directory to show how you're using it?

(I'm not going to ask for tests because they are being uncooperative at the moment and we need to document how to run the local vs. remote tests.)

@blakeprudhomme
Copy link
Contributor Author

Sure can! thanks.

Simply allows access to fetch the list of reason codes
@blakeprudhomme
Copy link
Contributor Author

blakeprudhomme commented May 12, 2017

because they are being uncooperative at the moment

@wsmoak Example added. I assume CI failing is related to the above comment?

@blakeprudhomme
Copy link
Contributor Author

Does anything else need to been done here?

Copy link
Contributor

@lscoates lscoates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @blakeprudhomme, merging this now - sorry for the delay!

@lscoates lscoates merged commit f4853d9 into chargify:master Jul 18, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants