Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bug: last rendered line gets ignored #1322

Closed
aymanbagabas opened this issue Feb 10, 2025 · 0 comments · Fixed by #1323
Closed

bug: last rendered line gets ignored #1322

aymanbagabas opened this issue Feb 10, 2025 · 0 comments · Fixed by #1323
Assignees
@aymanbagabas
Labels
bug Something isn't working

Comments

@aymanbagabas
Copy link
Member

Taken from #1317

I recently upgraded from bubbletea from v0.26.5 to v1.3.0 in my project: https://github.com/antonmedv/walk.

image

And I encountered some very strange behavior with rendering. You can try it yourself on walk version 1.11.0.

  • yank some file path [y]
  • see bar [copied: some path]
  • move cursor with arrows
  • last line disappeared! 👻

I was struggling to find a bug in my code, but after downgrading - everything is fine again.

Shottr 2025-02-08 19 49 14 Терминал 2025-02-08 19 49 46

Does somebody experience similar problems?
@aymanbagabas aymanbagabas added the bug Something isn't working label Feb 10, 2025
@aymanbagabas aymanbagabas self-assigned this Feb 10, 2025
aymanbagabas added a commit that referenced this issue Feb 10, 2025
@aymanbagabas
fix: renderer: use newline instead of cud1 to move cursor down
85a3482 
Using cud1 (`\x1b[B`) won't scroll the terminal if the cursor is already
at the bottom of the screen. Instead, use a newline character to move
the cursor down and scroll the terminal if necessary.

Fixes: #1322
@aymanbagabas aymanbagabas mentioned this issue Feb 10, 2025
Merged
aymanbagabas added a commit that referenced this issue Feb 10, 2025
@aymanbagabas
fix: renderer: use newline instead of cud1 to move cursor down (#1323)
771a101 
* fix: renderer: use newline instead of cud1 to move cursor down

Using cud1 (`\x1b[B`) won't scroll the terminal if the cursor is already
at the bottom of the screen. Instead, use a newline character to move
the cursor down and scroll the terminal if necessary.

Fixes: #1322

* chore(examples): update tesdata
aymanbagabas added a commit that referenced this issue Feb 10, 2025
@aymanbagabas
fix: renderer: use newline instead of cud1 to move cursor down
8741360 
Using cud1 (`\x1b[B`) won't scroll the terminal if the cursor is already
at the bottom of the screen. Instead, use a newline character to move
the cursor down and scroll the terminal if necessary.

Fixes: #1322
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@aymanbagabas aymanbagabas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: renderer: use newline instead of cud1 to move cursor down charmbracelet/bubbletea
1 participant
@aymanbagabas