Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(deps): dependabot #224

Merged
merged 5 commits into from
Jun 12, 2023
Merged

fix(deps): dependabot #224

merged 5 commits into from
Jun 12, 2023

Conversation

bashbunni
Copy link
Member

No description provided.

@bashbunni
Copy link
Member Author

https://github.com/charmbracelet/charm/blob/3d993528a0fc069ae176d6d4847012bdd4185142/server/storage/local/storage_test.go#LL23C31-L23C31
change this to filepath.Join(string(os.PathSeparator), "file") to fix build failing on Windows

@bashbunni
Copy link
Member Author

!!!!

@bashbunni bashbunni requested review from caarlos0, aymanbagabas and maaslalani and removed request for caarlos0 June 9, 2023 19:30
@bashbunni bashbunni merged commit 802af7a into main Jun 12, 2023
@bashbunni bashbunni deleted the fix/dependabot branch June 12, 2023 22:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@maaslalani maaslalani Awaiting requested review from maaslalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bashbunni @caarlos0 @aymanbagabas