Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: add bgColor type in RadialLinearScaleOptions #11081

Merged
merged 3 commits into from
Jan 30, 2023
Merged

fix: add bgColor type in RadialLinearScaleOptions #11081

merged 3 commits into from
Jan 30, 2023

Conversation

choichoijin
Copy link
Contributor

@choichoijin choichoijin commented Jan 22, 2023 •
edited
Loading

issue #11082

@choichoijin choichoijin reopened this Jan 29, 2023
@etimberg etimberg added the type: types Typescript type changes label Jan 29, 2023
@etimberg etimberg added this to the Version 4.2.1 milestone Jan 29, 2023
etimberg
etimberg reviewed Jan 29, 2023
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, but the linting is failing

LeeLenaleee
LeeLenaleee reviewed Jan 30, 2023
View reviewed changes
src/types/index.d.ts Outdated Show resolved Hide resolved
@LeeLenaleee
Update src/types/index.d.ts
0eb01b5 
remove trailing space
@etimberg etimberg merged commit 1684cf7 into chartjs:master Jan 30, 2023
@choichoijin choichoijin deleted the backgroundColor-type branch January 31, 2023 02:50
@choichoijin
Copy link
Contributor Author

Thank you!

@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@etimberg etimberg etimberg left review comments

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@choichoijin @etimberg @LeeLenaleee