wip - Implement OSX build #4611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Aug 3, 2017
| - provider: script | ||
| script: ./scripts/deploy.sh | ||
| skip_cleanup: true | ||
| on: |
There was a problem hiding this comment.
You could leave the deploy block in place and just add something along the lines of:
on:
all_branches: true
condition: `uname -s` == "Linux"
|
@andig I think there is restrictions for Travis builds running from a PR but would be better to experiment on your own fork with your own tokens and environment variables to avoid triggering unexpected deploy/release. |
|
@simonbrunel I've already removed all deployment code for sake of safety for now. I'm closing anyway since it seems OSX build won't make it into chartjs :( |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help with #4515
I'll clean the request up before it can be merged. Putting it here will allow me to see how it performs with the various chartjs tokens and environment variables in place.