Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Return correct label for value type axis #5920

Merged
merged 9 commits into from
Jan 17, 2019
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 16, 2018

@benmccann
Copy link
Contributor

@kurkle this change will have to be rebased

benmccann
benmccann previously approved these changes Jan 10, 2019
etimberg
etimberg previously approved these changes Jan 11, 2019
@kurkle kurkle dismissed stale reviews from etimberg and benmccann via 8f3c764 January 13, 2019 17:29
@kurkle
Copy link
Member Author

kurkle commented Jan 15, 2019

Another way of fixing this, thoughts?

benmccann
benmccann previously approved these changes Jan 15, 2019
@simonbrunel
Copy link
Member

simonbrunel commented Jan 16, 2019

@kurkle I think that's the solution I like the most. Since we are moving these methods in the base class, it may be the opportunity to make them explicitly private (prefixed by '_')? (IIRC, there was no "private" policy when I introduced these methods).

@kurkle
Copy link
Member Author

kurkle commented Jan 16, 2019

@kurkle I think that's the solution I like the most. Since we are moving these methods in the base class, it may be the opportunity to make them explicitly private (prefixed by '_')? (IIRC, there was no "private" policy when I introduced these method).

done

@simonbrunel simonbrunel added this to the Version 2.8 milestone Jan 17, 2019
@simonbrunel simonbrunel merged commit 7bbf3ca into chartjs:master Jan 17, 2019
@kurkle kurkle deleted the 5708 branch May 5, 2019 06:49
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants