-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Return correct label for value type axis #5920
Conversation
@kurkle this change will have to be rebased |
Another way of fixing this, thoughts? |
@kurkle I think that's the solution I like the most. Since we are moving these methods in the base class, it may be the opportunity to make them explicitly private (prefixed by '_')? (IIRC, there was no "private" policy when I introduced these methods). |
done |
Fixes #5708
https://codepen.io/kurkle/pen/bOepaQ (updated to 4abdc59)