Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Autoskip cleanup #6043

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Autoskip cleanup #6043

merged 1 commit into from
Feb 8, 2019

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Feb 4, 2019

There should be no functional changes in this PR. It's just a cleanup to make the code a bit easier to understand. _autoSkip was quite a large method previously

@benmccann benmccann force-pushed the autoskip-cleanup branch 2 times, most recently from 37d976c to fe8ed40 Compare February 4, 2019 16:09
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup!

@simonbrunel simonbrunel added this to the Version 2.8 milestone Feb 7, 2019
@simonbrunel simonbrunel requested a review from etimberg February 7, 2019 09:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants