Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make decimalPlaces private and update CDN links #6131

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Make decimalPlaces private and update CDN links #6131

merged 3 commits into from
Mar 13, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Mar 12, 2019

Couple of Issues I noticed in #6092

  1. I don't think we need to make helpers.decimalPlaces public
  2. We should not link to 2.7.3 version. So changed cdn links to jsDelivr for wildcard version support.

@kurkle kurkle added this to the Version 2.8 milestone Mar 12, 2019
@kurkle kurkle requested review from benmccann, nagix and etimberg March 12, 2019 15:39
etimberg
etimberg previously approved these changes Mar 12, 2019
View reviewed changes
benmccann
benmccann previously approved these changes Mar 12, 2019
View reviewed changes
nagix
nagix previously approved these changes Mar 13, 2019
View reviewed changes
@kurkle kurkle dismissed stale reviews from nagix, benmccann, and etimberg via fde75c5 March 13, 2019 07:11
@simonbrunel simonbrunel changed the title 2.8 preparation Make decimalPlaces private and update CDN links Mar 13, 2019
@kurkle
Copy link
Member Author

kurkle commented Mar 13, 2019

@simonbrunel pointed out this will probably be how users link, so updated to focus on a particular version.

@simonbrunel simonbrunel merged commit 75e76cf into chartjs:master Mar 13, 2019
@kurkle kurkle deleted the 2.8-prep branch May 5, 2019 06:33
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @simonbrunel
Make decimalPlaces private and update CDN links (chartjs#6131)
1279c9c
@renovate renovate bot mentioned this pull request Jun 1, 2021
Closed
1 task
This was referenced Jun 2, 2021
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@benmccann benmccann benmccann left review comments

@nagix nagix nagix left review comments

@etimberg etimberg etimberg left review comments

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@kurkle @benmccann @nagix @simonbrunel @etimberg