Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include src folder in release #7008

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link
Contributor

This is necessary in order to import just the files you want for tree shaking as proposed in #4461

@kurkle
Copy link
Member

kurkle commented Jan 26, 2020

Shouldn't the esm build be the on that supports tree shaking?
I think the points in #6105 are still valid.

@benmccann
Copy link
Contributor Author

Shouldn't the esm build be the on that supports tree shaking?

I think there's basically two options which I've outlined in #7009. What you're suggesting is option 1. I prefer option 2 overall though

I think the points in #6105 are still valid.

Good catch. I hadn't thought about the about the fact that we have a custom rollup plugin for importing CSS that our users would need too. I guess this doesn't really work that well if we want to keep that working the same way it does today

@benmccann benmccann closed this Jan 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants