fix: set acme_account_url even if some DNS records are not set #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perform_initial_checks may exit early and not add `acme_account_url` if required DNS records are not found. In this case other `cmdeploy run` fails with KeyError. To avoid this, `acme_account_url` should always be set. Unlike DNS checks, running acmetool may not fail due to network errors, so it is more reliable and should be checked first.
missytake
approved these changes
Oct 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform_initial_checks may exit early
and not add
acme_account_urlif required DNSrecords are not found.
In this case other
cmdeploy runfailswith KeyError.
To avoid this,
acme_account_urlshould always be set.Unlike DNS checks, running acmetool
may not fail due to network errors,
so it is more reliable and should be checked first.