Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve access to page function and shorts related session #1335

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

annarhughes
Copy link
Member

@annarhughes annarhughes commented Feb 18, 2025

What changes did you make and why did you make them?

Improved hasAccessToPage functionality whilst debugging an access issue (this was due to storyblok data in the end)
Fixed shorts.related_session to allow only one session object (previously allowed multiple and course objects) to avoid bugs if a course or multiple sessions is set instead

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 5:12pm

@annarhughes annarhughes marked this pull request as ready for review February 18, 2025 17:10
@annarhughes annarhughes merged commit aa92ccb into develop Feb 18, 2025
6 checks passed
@annarhughes annarhughes deleted the improve-hasAccessToPage branch February 18, 2025 17:14
Copy link

cypress bot commented Feb 18, 2025

Bloom frontend    Run #1049

Run Properties:  status check passed Passed #1049  •  git commit aa92ccb2a0: fix: access to page function and shorts related session (#1335)
Project Bloom frontend
Branch Review develop
Run status status check passed Passed #1049
Run duration 08m 47s
Commit git commit aa92ccb2a0: fix: access to page function and shorts related session (#1335)
Committer Anna Hughes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 9
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 77
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant