Improve documentation of the env file example #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
approved these changes
Jan 27, 2025
| FIREBASE_PROJECT_ID: z.string(), | ||
| FIREBASE_STORAGE_BUCKET: z.string(), | ||
| FIREBASE_STORAGE_BUCKET: z.string().optional(), |
There was a problem hiding this comment.
this one I guess can be removed altogether ?
There was a problem hiding this comment.
Yes. I thought we did not use those, but wanted to make sure before removing. Will edit tomorrow.
…d setting some variables as optional.
apognu
force-pushed
the
docs/improve-env-files
branch
from
d01a410 to
bdeba64
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same rationale as the backend one.
Big difference, though: this actually changes some code to mark some variables as optional. I do not think we use them for anything, from what I can see in the code and the Firebase project, so having them in the configuration file might clutter it for nothing.