fix: remove user and entitlements from auth session cookie #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChibiBlasphem
force-pushed
the
fix/remix-cookie-length
branch
from
e9ee45a to
e364021
Compare
Pascal-Delange
approved these changes
Jan 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too much information was stored in auth session cookie, namely "user" and "entitlements" taking too much space in the cookie (which are limited to 4KB in size in total for a domain) nearing the maximum size they can take.
They were only used in the
isAuthenticatedauth service function.What we did is remove
userandentitlementsfrom the cookie and instead of reading them from the cookie in theisAuthenticatedauth service function, we now call the call the dedicated services.