fix(lang): respect fallback languages #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorin-davidoi
force-pushed
the
lang-respect-fallbacks
branch
3 times, most recently
from
a78dbaf to
405833d
Compare
If `navigator.languages` returns `['da', 'en-US', 'en']`, and the Danish
language is not available, the user interface should be in English.
Currently it is shown in Norwegian, because only `'da'` is taken into
account when deciding on the preferred language (and `match` selects
`nb-NO` using the default `'best fit'` algorithm).
While the Norwegian and Danish languages are similar, I would argue that
this is a bug, as `navigator.languages` cleary states that the fallback
language should be English.
Another potential solution would be to pass `{ algorithm: 'lookup' }` to
the `match` function. However, this might break some cases when a
`'best fit'` approach would be appropriate (e.g. Swiss German falling
back to German).
See https://helvede.net/@jwcph/113497955274343365.
sorin-davidoi
force-pushed
the
lang-respect-fallbacks
branch
from
405833d to
46b5faa
Compare
cheeaun
approved these changes
Nov 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
navigator.languagesreturns['da', 'en-US', 'en'], and the Danish language is not available, the user interface should be in English.Currently it is shown in Norwegian, because only
'da'is taken into account when deciding on the preferred language (andmatchselectsnb-NOusing the default'best fit'algorithm).While the Norwegian and Danish languages are similar, I would argue that this is a bug, as
navigator.languagescleary states that the fallback language should be English.Another potential solution would be to pass
{ algorithm: 'lookup' }to thematchfunction. However, this might break some cases when a'best fit'approach would be appropriate (e.g. Swiss German falling back to German).See https://helvede.net/@jwcph/113497955274343365.