Skip to content

Commit

Permalink
fix(package): Use cheerio-select-tmp until naming issue is resolved
Browse files Browse the repository at this point in the history
Fixes #1576
  • Loading branch information
fb55 committed Dec 21, 2020
1 parent 52066f3 commit 3751929
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/api/traversing.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* @module cheerio/traversing
*/

var select = require('cheerio-select');
var select = require('cheerio-select-tmp');
var utils = require('../utils');
var domEach = utils.domEach;
var uniqueSort = require('htmlparser2').DomUtils.uniqueSort;
Expand Down
2 changes: 1 addition & 1 deletion lib/static.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var htmlparser2Adapter = require('parse5-htmlparser2-tree-adapter');
var serialize = require('dom-serializer').default;
var defaultOptions = require('./options').default;
var flattenOptions = require('./options').flatten;
var select = require('cheerio-select').select;
var select = require('cheerio-select-tmp').select;

This comment has been minimized.

Copy link
@fregante

fregante Jan 13, 2021

What's up with this line? It wasn't valid before and it's not valid after this commit

This comment has been minimized.

Copy link
@fb55

fb55 Jan 14, 2021

Author Member

How isn't it valid?

This comment has been minimized.

Copy link
@fregante

fregante Jan 14, 2021

Screen Shot

🤔

This comment has been minimized.

Copy link
@fregante

fregante Jan 14, 2021

Only correction is that it was valid before, but now it should be

var select = require('cheerio-select-tmp').select;

or

var {select} = require('cheerio-select-tmp');
var parse5 = require('parse5');
var parse = require('./parse');

Expand Down
7 changes: 4 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"node": ">= 0.12"
},
"dependencies": {
"cheerio-select": "github:cheeriojs/cheerio-select",
"cheerio-select-tmp": "^0.1.0",
"dom-serializer": "~1.2.0",
"domhandler": "^4.0.0",
"entities": "~2.1.0",
Expand Down

0 comments on commit 3751929

Please # to comment.