fix(traversing): Filter text nodes in find function (#1680)

cheeriojs · Jan 19, 2021 · 9b28b49 · 9b28b49
1 parent bc2e636
commit 9b28b49
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/api/traversing.js b/lib/api/traversing.js
@@ -52,7 +52,9 @@ exports.find = function (selectorOrHaystack) {
   var elems = reSiblingSelector.test(selectorOrHaystack)
     ? context
     : context.reduce(function (newElems, elem) {
-        return newElems.concat(elem.children.filter(isTag));
+        return Array.isArray(elem.children)
+          ? newElems.concat(elem.children.filter(isTag))
+          : newElems;
       }, []);
 
   var options = Object.assign({ context: context }, this.options);

diff --git a/test/api/traversing.js b/test/api/traversing.js
@@ -29,6 +29,12 @@ describe('$(...)', function () {
       expect($('#fruits').find('.apple')[0].attribs['class']).toBe('apple');
     });
 
+    // #1679 - text tags not filtered
+    it('(single) : should filter out text nodes', function () {
+      var $root = $('<html>\n' + fruits.replace(/></g, '>\n<') + '\n</html>');
+      expect($root.find('.apple')[0].attribs['class']).toBe('apple');
+    });
+
     it('(many) : should find all matching descendant', function () {
       expect($('#fruits').find('li')).toHaveLength(3);
     });