Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Setting image alt using prop does not work #883

Closed
alexturpin opened this issue Jun 22, 2016 · 0 comments · Fixed by #1579
Closed

Setting image alt using prop does not work #883

alexturpin opened this issue Jun 22, 2016 · 0 comments · Fixed by #1579

Comments

@alexturpin
Copy link

See following Tonic for simple way to reproduce the problem:
https://tonicdev.com/alexturpin/576aadba8f0383130020fdfe

Similar code in jQuery works as intended:
https://jsfiddle.net/hew0rcsq/

The prop does get set on the node object and eventually passed to the dom-serializer but I can't see the serializer doing anything with that. Should cheerio maybe set that prop as an attribute?
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(prop): Update attribute value when setting prop cheeriojs/cheerio
1 participant
@alexturpin