Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

jsdocs: switch to clean-jsdoc-theme #1648

Merged
merged 2 commits into from
Jan 9, 2021
Merged

jsdocs: switch to clean-jsdoc-theme #1648

merged 2 commits into from
Jan 9, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 4, 2021

Not tied to this, just wanted something better looking. If anyone has any theme suggestions let me know :)

PS. Not sure if it's worth adding Netlify to the repo for automatic PR previews, but the free plan should suffice. Another alternative would be Vercel.

@fb55 fb55 marked this pull request as ready for review January 9, 2021 20:00
@fb55 fb55 enabled auto-merge (squash) January 9, 2021 20:02
@fb55
Copy link
Member

fb55 commented Jan 9, 2021

Thanks a lot for this! I'm not the biggest fan of the clean-jsdoc-theme, but I do agree that it is a step forward for our website.

I have tried several JSDoc themes, but none of them came close to what I'd like to see. TypeDoc does seem to have some nicer themes, making me consider #1641 even more 😄

@fb55 fb55 disabled auto-merge January 9, 2021 20:04
@fb55 fb55 merged commit a336301 into cheeriojs:main Jan 9, 2021
@XhmikosR XhmikosR deleted the jsdocs-theme branch January 9, 2021 20:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants