Update cookbook to modern standards #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, this seems great. I'll run some local validation and get this merged ASAP. Thanks! 🤘 |
tas50
reviewed
Aug 11, 2017
| @@ -10,6 +10,8 @@ | |||
| respond_to?(:source_url) | |||
| issues_url 'https://github.com/chef-partners/dcos-cookbook/issues' if | |||
| respond_to?(:issues_url) | |||
There was a problem hiding this comment.
If you require chef 12 you can nuke these respond_to and issues_url and source_url.
There was a problem hiding this comment.
Lowered it to 11, since there's nothing 12+ specific here.
Updated several items to improve the cookbook. - Use Delivery for testing - Use Kitchen Dokken on Ubuntu 16.04 in Travis CI - Update metadata to include missing items/update license string - Cleanup invalid syntax in default recipe Signed-off-by: Chris Gianelloni <wolf31o2@gmail.com>
|
Thanks for this Chris! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated several items to improve the cookbook.
Signed-off-by: Chris Gianelloni wolf31o2@gmail.com