Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing the chefstyle errors and updating ruby 3.1 and chef 18.x in verify pipeline #231

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fixing the chefstyle errors and updating ruby 3.1 and chef 18.x in verify pipeline #231

wants to merge 10 commits into from

Conversation

nikhil2611
Copy link
Contributor

@nikhil2611 nikhil2611 commented Dec 13, 2023 •
edited
Loading

Description

Updated the verify pipeline to run on ruby 3.1 for all platforms.
Updated chef to v18.x
Fixed the chefstyle error

Related Issue

https://chefio.atlassian.net/browse/CHEF-1540

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

@nikhil2611
updated the undo path for windows
3767418 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611 nikhil2611 requested review from a team as code owners December 13, 2023 09:44
@github-actions GitHub Actions
Copy link

Simplecov Report

Covered Threshold
98.51% 90%

@nikhil2611 nikhil2611 changed the title updated the undo path for windows Updated the undo path(from '\\' to "/") for undelete command for windows OS Dec 13, 2023
@nikhil2611
updated verify pipeline to run spec for ruby 3.1
d299edf 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
test case and chef style fix
b59efaf 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
chefstyle to back 2.7
dace5d0 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
chefstyle fixes
a99b7bb 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated gemfilr
51e4e41 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
chefstyle fixes
5675d97 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
test cases fixes
a51a8b9 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated HTTPClientException
78b46ed 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated pipeline
f7a99ac 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
10.5% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 10.5% 10.53% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@nikhil2611 nikhil2611 changed the title Updated the undo path(from '\\' to "/") for undelete command for windows OS Fixing the chefstyle errors and updating ruby 3.1 and chef 18.x in verify pipeline Dec 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nikhil2611