Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

S3 Publisher: Print the download URL for published artifacts #829

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Mar 19, 2018

Description

When the S3 uploading is completed, the download URL will be printed to the Omnibus log output. That is useful if S3 is used as a final hosting platform for these artifacts, so operator can get a result URL directly from the omnibus output.

 Example

$ bundle exec omnibus publish s3 my-bucket --acl public --region eu-central-1 "./pkg/*.dmg"
                    [CLI] I | 2018-03-19T09:36:47+01:00 | Using config from 'omnibus.rb'
       [Command::Publish] I | 2018-03-19T09:36:47+01:00 | Using config from 'omnibus.rb'
            [S3Publisher] I | 2018-03-19T09:36:47+01:00 | Starting S3 publisher
            [S3Publisher] I | 2018-03-19T09:36:48+01:00 | Uploading 'myproj-0.1.0+20180315142042-1.dmg'
            [S3Publisher] I | 2018-03-19T09:36:58+01:00 | Uploading is completed. Download URL (public-read): https://my-bucket.s3.eu-central-1.amazonaws.com/current/myproj/0.1.0%2B20180315142042/mac_os_x/10.10/myproj-0.1.0%2B20180315142042-1.dmg
Published 'myproj-0.1.0+20180315142042-1.dmg' for mac_os_x-10.10

Note: Metadata URL is printed to debug log level only, so it's not shown in the example above.

@legal90 legal90 requested a review from a team as a code owner March 19, 2018 08:50
@legal90
Copy link
Contributor Author

legal90 commented Mar 19, 2018

As I can see, Rubocop offenses (in Travis CI build) are not related to this PR and should be fixed in a standalone PR.

@legal90
Copy link
Contributor Author

legal90 commented May 2, 2018

I've rebased the branch. But TravisCI and AppVeyor builds still look broken (is not related to this PR)

@legal90
Copy link
Contributor Author

legal90 commented Nov 19, 2018

cc @chef/omnibus-maintainers is anyone interested in this?

@tas50
Copy link
Contributor

tas50 commented Nov 19, 2018

Ping @scotthain

Copy link
Contributor

@scotthain scotthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - let's get it rebased and merged!

When the uploading is completed, the download URL will be printed to the Omnibus log output.

Signed-off-by: Mikhail Zholobov <legal90@gmail.com>
@legal90
Copy link
Contributor Author

legal90 commented Dec 3, 2018

Sorry for a delay. I've rebased the branch now

@scotthain
Copy link
Contributor

Thanks @legal90 much appreciated!

@scotthain scotthain merged commit 28571be into chef:master Dec 3, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants