Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Drop testing of unsupported platforms #875

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Drop testing of unsupported platforms #875

merged 1 commit into from
Feb 1, 2019

Conversation

marcparadise
Copy link
Member

@marcparadise marcparadise commented Feb 1, 2019 •
edited
Loading

Description

Dropped unit testing of the following platforms, which are unsupported and causing CI failures:

  • nexus
  • ios_xr

Also dropped the same from MetaData#truncate_platform_version
since it's not supported.

Signed-off-by: Marc A. Paradise marc.paradise@gmail.com

Maintainers

Please ensure that you check for:

  • If this change impacts git cache validity, it bumps the git cache
    serial number
  • If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

@marcparadise
Drop testing of unsupported platforms
e539954 
Dropped unit testing of the following platforms, which are unsupported:

* nexus
* ios_xr

Also dropped the same from `MetaData#truncate_platform_version`
since it's not supported.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise requested a review from a team as a code owner February 1, 2019 18:03
@marcparadise marcparadise mentioned this pull request Feb 1, 2019
Merged
3 tasks
robbkidd
robbkidd approved these changes Feb 1, 2019
View reviewed changes
Copy link

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop test

tas50
tas50 approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@tas50 tas50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@marcparadise marcparadise merged commit 12c56b7 into master Feb 1, 2019
@chef-ci chef-ci deleted the mp/drop-unsupported-platforms branch February 1, 2019 18:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lamont-granquist lamont-granquist lamont-granquist approved these changes

@robbkidd robbkidd robbkidd approved these changes

@tas50 tas50 tas50 approved these changes

@scotthain scotthain scotthain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcparadise @lamont-granquist @robbkidd @tas50 @scotthain