Improve logging when overriding a version when there is no default #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you specify a version when there is no default you get a nice message like this that has printed out a nil value: [Builder: bundler] I | 2019-03-20T04:13:10+00:00 | Version overridden from to 2.0.1 This would change this message to this instead: [Builder: bundler] I | 2019-03-20T04:13:10+00:00 | Version overridden from n/a to 2.0.1 Signed-off-by: Tim Smith <tsmith@chef.io>
lamont-granquist
approved these changes
Mar 20, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you specify a version when there is no default you get a nice message like this that has printed out a nil value:
[Builder: bundler] I | 2019-03-20T04:13:10+00:00 | Version overridden from to 2.0.1
This would change this message to this instead:
[Builder: bundler] I | 2019-03-20T04:13:10+00:00 | Version overridden from n/a to 2.0.1
Signed-off-by: Tim Smith tsmith@chef.io