Switch off my fork of rspec-json_expectations & fix spec failures #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream released the fix we needed. Signed-off-by: Tim Smith <tsmith@chef.io>
We added this file to the generator and didn't update the spec Signed-off-by: Tim Smith <tsmith@chef.io>
scotthain
approved these changes
Jun 13, 2019
tas50
force-pushed
the
rspec
branch
3 times, most recently
from
a679728 to
c64ce78
Compare
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
changed the title
lamont-granquist
approved these changes
Jun 13, 2019
marcparadise
approved these changes
Jun 13, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream released the fix we needed.
This also fixes spec failures to get the build green. It forces the spec encoding to UTF 8 to prevent failures in the new Buildkite containers, adds a missing array value that was causing a spec failure, and configures rspec to give us longer diffs when a comparison fails.
Signed-off-by: Tim Smith tsmith@chef.io