feat: improve signal kinds for ranges and integrals #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ae6ffdf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://440b5650.nmrium.pages.dev |
| Branch Preview URL: | https://improve-kind-in-ranges-and-i.nmrium.pages.dev |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
==========================================
- Coverage 53.40% 52.95% -0.46%
==========================================
Files 52 52
Lines 2584 2559 -25
Branches 91 91
==========================================
- Hits 1380 1355 -25
Misses 1202 1202
Partials 2 2
☔ View full report in Codecov by Sentry. |
|
When renaming ranges become undefined. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it could be better to have a special react context for the computed values instead of having a custom hook for each one.