Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: improve signal kinds for ranges and integrals #2667

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

hamed-musallam
Copy link
Member

close #2600

@hamed-musallam hamed-musallam linked an issue Sep 13, 2023 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 571ec28
Status: ✅  Deploy successful!
Preview URL: https://93460e8a.nmrium.pages.dev
Branch Preview URL: https://improve-kinds-column.nmrium.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 91.42% and project coverage change: -0.16% ⚠️

Comparison is base (53fff90) 53.64% compared to head (571ec28) 53.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2667      +/-   ##
==========================================
- Coverage   53.64%   53.49%   -0.16%     
==========================================
  Files          49       50       +1     
  Lines        2457     2449       -8     
  Branches       86       88       +2     
==========================================
- Hits         1318     1310       -8     
  Misses       1138     1138              
  Partials        1        1              
Files Changed Coverage Δ
src/data/data1d/Spectrum1D/ranges/addRange.ts 25.00% <50.00%> (ø)
...rc/data/data1d/Spectrum1D/ranges/checkRangeKind.ts 75.00% <50.00%> (ø)
src/data/utilities/RangeUtilities.ts 29.66% <50.00%> (ø)
src/data/constants/signalsKinds.ts 100.00% <100.00%> (ø)
src/utils/stringCapitalize.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam hamed-musallam merged commit a8ca174 into main Sep 13, 2023
@hamed-musallam hamed-musallam deleted the improve-kinds-column branch September 13, 2023 09:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kind in ranges and integrals
1 participant