Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix identity authentication #242

Merged
merged 11 commits into from
Dec 7, 2021
Merged

Fix identity authentication #242

merged 11 commits into from
Dec 7, 2021

Conversation

askolesov
Copy link
Contributor

@askolesov askolesov commented Dec 6, 2021 •
edited
Loading

No description provided.

@askolesov askolesov marked this pull request as draft December 6, 2021 14:16
@askolesov askolesov marked this pull request as ready for review December 6, 2021 19:52
@askolesov askolesov marked this pull request as draft December 6, 2021 19:52
@askolesov askolesov marked this pull request as ready for review December 6, 2021 19:52
ankurdotb
ankurdotb reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave this to @Toktar and @anikitinDSR to look in detail

x/cheqd/types/keys.go Show resolved Hide resolved
@askolesov askolesov requested a review from ankurdotb December 7, 2021 11:54
@askolesov askolesov merged commit 2e2a3c0 into main Dec 7, 2021
@askolesov askolesov deleted the fix/identity-auth branch December 7, 2021 12:31
lampkin-diet
lampkin-diet reviewed Dec 7, 2021
View reviewed changes
tests/cli/tests/test_rotate_key.sh

# sed in macos requires extra argument

sed_extension=''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still needed?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lampkin-diet lampkin-diet lampkin-diet left review comments

@Toktar Toktar Toktar approved these changes

@ankurdotb ankurdotb Awaiting requested review from ankurdotb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@askolesov @ankurdotb @Toktar @lampkin-diet