Ability to specify DataWriterType and new type that prefers unix timestamp #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taining backwards compatibility with the current options. Also allowing a new output type CSV_TS which prefers the unix timestamp of the entry first.
|
Hi Samuel, Thank you very much for your contribution including the unittest! I have merged it with my master branch and refactored the args parsing functionality into its own class. Best regards, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case there I'd like the csv output to prefer the full unix timestamp if available. That was simple enough, created a new DataWriterType and preferred the unix timestamp if available.
Added that as a -t option to the command line arguments while maintaining backwards compatibility with existing arguments.