Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Promotion Avg & Total To Summary #203

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

amcrn
Copy link
Contributor

@amcrn amcrn commented Jul 31, 2018

Adds avgPromotion and promotionTotal to the Summary output.

Example:

avgPromotion; 2,925; K
promotionTotal; 3,820; M

@amcrn amcrn force-pushed the enh/promotion-summary branch 3 times, most recently from a18f92b to 488048b Compare July 31, 2018 21:30
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #203 into develop will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #203      +/-   ##
=============================================
+ Coverage      69.39%   69.77%   +0.37%     
- Complexity      1467     1475       +8     
=============================================
  Files            145      145              
  Lines           8366     8374       +8     
  Branches        1368     1370       +2     
=============================================
+ Hits            5806     5843      +37     
+ Misses          1981     1955      -26     
+ Partials         579      576       -3
Impacted Files Coverage Δ Complexity Δ
...raum/perf/gcviewer/exp/impl/SummaryDataWriter.java 87.68% <100%> (+9.73%) 31 <0> (+5) ⬆️
.../com/tagtraum/perf/gcviewer/util/MemoryFormat.java 88.88% <0%> (+4.76%) 12% <0%> (+1%) ⬆️
...va/com/tagtraum/perf/gcviewer/util/TimeFormat.java 65.62% <0%> (+12.5%) 6% <0%> (+1%) ⬆️
...om/tagtraum/perf/gcviewer/util/FormattedValue.java 90.9% <0%> (+36.36%) 4% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db04c2...129829d. Read the comment docs.

Adds avgPromotion and promotionTotal to the Summary output.

Example:

    avgPromotion; 2,925; K
    promotionTotal; 3,820; M
@chewiebug chewiebug merged commit 129829d into chewiebug:develop Aug 1, 2018
@chewiebug
Copy link
Owner

chewiebug commented Aug 1, 2018 via email

@chewiebug chewiebug added this to the 1.36 milestone Aug 1, 2018
@amcrn amcrn deleted the enh/promotion-summary branch August 1, 2018 16:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants