Fixes for latest changes in G1GC logs #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Dennis
This looks like a nice pull request!
I have some questions: How did you obtain uptime stamps with
milliseconds? What platform did you use (windows, linux, macos)? What
jdk did you use (openjdk, oraclejdk)? What arguments did you use to
create the gc log file? I never managed to get those milliseconds in the
uptime stamp.
Best regards,
Jörg
|
|
Used "java version "12.0.1" 2019-04-16" on MacOS and Ubuntu 16.04.3 LTS with the following arguments:
uptimemillis was simply an optional argument that I added in my own test environment and not a JVM-specific change. I'll rephrase the PR description. |
chewiebug
added a commit
that referenced
this pull request
Sep 17, 2019
chewiebug
added a commit
that referenced
this pull request
Sep 17, 2019
chewiebug
added a commit
that referenced
this pull request
Sep 17, 2019
Feature/#228/support uptimemillis
|
Ah - now it is clear, thank you very much! I have had to rebase your branch on top of the develop branch, because the travis build configuration was broken. I have merged your commits into develop. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for "Archive regions" from G1GC in latest JDK.
Support for "uptimemillis" GC logging argument.