fix problem "failed to recognize file format" on valid gc-log #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic chars of GC Type not in first 3 KB)
|
Hi Andrey, Thank you very much for providing this fix! In my expirience it is quite rare that recognition of the correct DataReader is not possible within the first 3KB so it is enough to reduce the probability that the problem occurs with what your implementation does. I have made a few tests - worst case speed is good enough for me. Regards, Jörg |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: specific chars of GC type not in first 3 KB.
This does not completely solve the problem, but reduces its impact.
Corrections do not violate the concept of code. Therefore, the speed of the worst situations is not the best possible.